From a90b47a49caa67d166c01394f4a4396c3fc56b32 Mon Sep 17 00:00:00 2001 From: Guillem Jover Date: Wed, 23 Jan 2013 02:24:22 +0100 Status: applied Debbug: 670963 Subject: [PATCH 2/3] c/binaries.desc: Expands tag description to explain how to add LFS Signed-off-by: Guillem Jover --- checks/binaries.desc | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/checks/binaries.desc b/checks/binaries.desc index d24e045..9f0f24a 100644 --- a/checks/binaries.desc +++ b/checks/binaries.desc @@ -352,7 +352,14 @@ Info: The listed ELF binary appears to be built without "Large File Support" (LFS). If so, it may not be able to handle large files correctly. . - To support large files, ensure that _FILE_OFFSET_BITS is - defined and set to 64 before the relevant files are included. This - can be done by using the AC_SYS_LARGEFILE macro with - autoconf. + To support large files, code review might be needed to make sure that + those files are not slurped into memory or mmap(2)ed, and that correct + 64-bit data types are used (ex: off_t instead of ssize_t), etc. Once + that has been done ensure _FILE_OFFSET_BITS is defined and + set to 64 before the relevant files are included. This can be done by + using the AC_SYS_LARGEFILE macro with autoconf. Take into + account that even if this tag is not emitted, that does not mean the + binary is LFS-safe (ie. no OOM conditions, file truncation or overwrite + will happen). Also note that enabling LFS on a shared library is not + always safe as it might break ABI in case some of the exported types + change size, in those cases a SOVERSION bump might be required. -- 1.8.1.1